feat: client-side prerequisite events #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwaldren-ld
force-pushed
the
cw/sdk-806-client-prereqs
branch
from
c2c1e53
to
9fd6707
Compare
cwaldren-ld
force-pushed
the
cw/sdk-806-client-prereqs
branch
from
7ac50b0
to
8a6d14b
Compare
cwaldren-ld
commented
Oct 28, 2024
| { | ||
| prerequisites ??= new List<string>(); | ||
| prerequisites.Add(reader.GetString()); | ||
| } |
There was a problem hiding this comment.
Doing the null coalescing operator because otherwise, we'd potentially construct an empty prereq array if the JSON value is null.
tanderson-ld
approved these changes
Oct 29, 2024
|
Noting that the Server SDK big segments tests failed, as well as the contract tests at one point (but passed upon re-run). These changes are entirely to the Client SDK, so I'm going to merge anyways. |
cwaldren-ld
pushed a commit
that referenced
this pull request
Nov 1, 2024
🤖 I have created a release *beep* *boop* --- ## [5.3.0](LaunchDarkly.ClientSdk-v5.2.1...LaunchDarkly.ClientSdk-v5.3.0) (2024-10-31) ### Features * client-side prerequisite events ([#24](#24)) ([f5828cb](f5828cb)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows the client SDK to deserialize
prerequisitesfrom the flag model and then emit prerequisite evaluation events.