Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prepare CI #425

Merged
merged 4 commits into from
May 16, 2024
Merged

prepare CI #425

merged 4 commits into from
May 16, 2024

Conversation

barryoneill
Copy link
Member

@barryoneill barryoneill commented May 16, 2024

The CI wasn't properly running tests. Fixing up the code that was failing once that was resolved.

@barryoneill barryoneill requested a review from semenodm as a code owner May 16, 2024 13:46
// case Some(latest) =>
// mkNewEvent(evt).andThen(finalizeNewEvent).run(latest)
// case None => Some(evt)
// }
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried this, it puts events in reverse order - I think the existing impl is fine

@barryoneill barryoneill requested a review from JennyLeahy May 16, 2024 14:52
@barryoneill barryoneill merged commit 5827ed7 into main May 16, 2024
3 checks passed
@barryoneill barryoneill deleted the ci branch May 16, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant