Add furtex locks to collections.deque #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1814,12 +1977,14 @@ deque_reviter(dequeobject *deque) | |||
| it = PyObject_GC_New(dequeiterobject, &dequereviter_type); | |||
| if (it == NULL) | |||
| return NULL; | |||
| deque_lock(deque); | |||
| it->b = deque->rightblock; | |||
| it->index = deque->rightindex; | |||
| Py_INCREF(deque); | |||
There was a problem hiding this comment.
Just to make sure I understand correctly: this Py_INCREF is fine where it is because the call will be holding a reference (so there's no risk of the refcount going to 0), right?
|
Other than the issues I've pointed out already, LGTM. |
|
I apologize for introducing conflicts into your merge request. But the whole platform abstraction was icky cubed. |
|
FWIW, I'm guessing Christian has walked away from this work too. Unless there are any other suggestions, I'll do my own review and update the patch. (Eventually.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.