Allow clients to specify whether or not to skip the database's final …

…snapshot
larribas · Aug 9, 2020 · 14ddf5a · 14ddf5a
1 parent 6e55b95
commit 14ddf5a
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/rds.tf b/rds.tf
@@ -70,7 +70,7 @@ resource "aws_rds_cluster" "backend_store" {
   availability_zones        = data.aws_availability_zones.available.names
   master_username           = "ecs_task"
   database_name             = "mlflow"
-  skip_final_snapshot       = true
+  skip_final_snapshot       = var.database_skip_final_snapshot
   final_snapshot_identifier = var.unique_name
   master_password           = data.aws_secretsmanager_secret_version.db_password.secret_string
   backup_retention_period   = 14

diff --git a/terratest/examples/main.tf b/terratest/examples/main.tf
@@ -56,7 +56,8 @@ module "mlflow" {
   load_balancer_ingress_cidr_blocks = var.is_private ? [module.vpc.vpc_cidr_block] : ["0.0.0.0/0"]
   load_balancer_is_internal         = var.is_private
   artifact_bucket_id                = var.artifact_bucket_id
-  database_password_secret_arn      = aws_secretsmanager_secret.db_password.arn
+  database_password_secret_arn      = aws_secretsmanager_secret_version.db_password.secret_id
+  database_skip_final_snapshot      = true
 }
 
 resource "aws_lb_listener" "http" {

diff --git a/variables.tf b/variables.tf
@@ -98,6 +98,11 @@ variable "database_max_capacity" {
   description = "The maximum capacity for the Aurora Serverless cluster. Aurora will scale automatically in this range. See: https://docs.aws.amazon.com/AmazonRDS/latest/AuroraUserGuide/aurora-serverless.how-it-works.html"
 }
 
+variable "database_skip_final_snapshot" {
+  type = bool
+  default = false
+}
+
 variable "artifact_bucket_id" {
   type        = string
   default     = null