[5.x] Enhance query preview when using the pgsql driver #1486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this PR @morloderex! |
driesvints
added a commit
that referenced
this pull request
Jun 27, 2024
This reverts commit 1394592.
driesvints
added a commit
that referenced
this pull request
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to fix the rendering issue that was reported in #1435
It does it by simply using the laravel framework build-in sql formatting logic if the laravel version is above 10.x. And appending the driver name to telescope content so that the
sql-formattingjavascript formatting library can format it in the correct dialect, while still falling back to use default of sql if it is not present.I have also updated the javascript highlighter to it's own component in order to detect the correct dialect for psgql to take place.
However there is a breaking change with doing it in this way due to the framework's build-in sql formatting logic doesn't support named bindings. But given that framework's query builder itself only supports
?parameters anyway i don't really see that as a huge issue.