Vue + Inertia useForm now uses an object compatible signature #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@juanparati tests fail here |
|
@driesvints : I had to suppress incompatible type errors for inertiaClearErrors and inertiaReset. I could not change the parameters signature for the "reset" method because precognitiveForm.setErrors uses Record<string, unknown> and it's a main precognition method. If I change the setErrors signature for the method I will break other packages. I will see if I can come in the following days with a more elegant solution that can also fix the issue with the useForm return type and I will submit a new pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the solution to #63.
The signature for "useForm" (Vue + InertiaJS package) was changed to object instead of Record<string, unknown> so it's going to be compatible with the native InertiaJS "useForm" that accepts also an object (type FormDataType = object).
"usePrecognitiveForm" type was hydrated as Record<string, unknown> so it should not break the compatibility.
Record<string, unknown> it's basically an object, so everything should work as expected.
I did a test with with Typescript 5.3.3.