[1.x] Allow external drivers to retrieve defined features for the given scope #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just tested this and it works perfectly! |
|
@tomirons what are you using for LaunchDarkly+Pennant? Is there a composer package, or did you roll your own? edit: my team is about to implement LD in a new app 😅 |
|
@cosmastech there are a couple of drivers already for LaunchDarkly but the SDK versions are outdated. We're currently implementing our own driver. One of the last hurdles is finding a way to efficiently cache the results from LD. The response from LD can take anywhere from ~150ms to ~1000ms and we don't want that to impact users. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new interface that allows 3rd party drivers that define features in their own platform to provide a list of features for the given scope.
One of the nice things about Pennant is it has support for 3rd party drivers, such as LaunchDarkly. When using an external driver where the features are defined in a different system, it is not currently possible to retrieve the features for a given user with the recent improvements made to the
Feature::all()functionality.This PR introduces a new interface allowing them to provide a feature list if they wish.