[1.x] Extract insert all #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timacdonald
commented
May 29, 2024
| @@ -222,7 +216,7 @@ public function get($feature, $scope): mixed | |||
| $this->insert($feature, $scope, $value); | |||
| } catch (UniqueConstraintViolationException $e) { | |||
| if ($this->retryDepth === 1) { | |||
| throw new RuntimeException('Unable to insert feature value from the database.', previous: $e); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extracts an
insertManymethod to make extending the database driver easier.Some of the community (#104 (comment), #100) are extending the driver to add custom fields to the features table. With the recent changes unique constraint handling (#104) we introduced a new insert query that is not able to be intercepted in an extended class.
This PR extracts the query out to an
insertManymethod to make it easier to intercept and decorate.Additionally it:
insertmethod a proxy to the newinsertManymethod.