Expo Push Notifications #121
Conversation
|
I'll sort the styles out shortly! |
README.md
Outdated
|
|
||
| ## Testing | ||
|
|
||
| TODO |
There was a problem hiding this comment.
Can just leave default command here
There was a problem hiding this comment.
I thought I added that back in before pushing, after writing the tests. Whoops! Fixed :)
composer.json
Outdated
| "require": { | ||
| "php": ">=7.4 | ^8.0", | ||
| "ext-json": "*", | ||
| "guzzlehttp/guzzle": "^7.3", |
There was a problem hiding this comment.
Done! Tests still passing! Woo!
|
Hey @atymic -- changes have been pushed :) |
|
Would love to get this merged and give it a shot on a project of mine. Ended up here doing a quick pre-cursory check to see if something already existed before I made one internally. |
|
I'll set it up now :) |
|
@nicko170 please PR here when you can. I'll set up everything else up once done! |
|
Hey @atymic I've tried to get in touch with Nick to take ownership of / collab on the repo, but he's no longer replying. I can't really PR it too since it's a channel that already exists, so I've created and released my own version of the notification channel here: https://github.com/dive-be/laravel-expo-channel. It works flawlessly, and I'd like to merge it with the LNC project. If it's fine for you, I'm prepared to archive that repo, use the LNC skeleton and migrate the codebase to the new repo. Can we proceed with this? What do you think? |
|
@mabdullahsari please email me at [email protected], will set you up :) |
Done! |
|
Hey @atymic -- any update on this? Thanks 🙏 (Haven't received any e-mail reply) |
This relates to #117 - I saw this when I was mid-way through adding this support in a local project, so decided to build it here instead :)