Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

made optional data format args actually optional #725

Closed
wants to merge 3 commits into from

Conversation

TTF2050
Copy link

@TTF2050 TTF2050 commented Jun 16, 2024

Functions like add_image and add_video indicate that the dataformats arg is optional. However, there was no code to handle the None case. This commit adds a function that enables automatic determination of which channel is the color channel and invokes it whenever dataformats is None. It makes assumptions about the ordering of the other channels, but it should cover 80% of use cases.

@lanpa
Copy link
Owner

lanpa commented Nov 16, 2024

Closing as test is not passed after fixing trivial linting errors.

@lanpa lanpa closed this Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants