New Applications + New Features DEV -> Main #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* wrote some down and added block of code for state prep * wrote more on background of application and initial state * finished writing background for qcd problem * dynamics implemented for qcd * cleaned up nb * getting resource estimates now from qcd that actually includes correct neighbor interactions * cleaned up qcd notebook * cleaned up qcd notebook * fixed bug for normalization factor * made changes to random variables to grab random numbers from a normal gaussian distribution and changed evolution time to be sqrt(N) where N is the number of neutrinos * modified grabbing params for hamiltonian generation * adding script file to generate resource estimates for QCD * modified gitignore to account for DS_STORE files * tweaks to qcd script * added files and section for analysis of resource estimates from performing a sweep * Updated pylint badge * Updated pylint badge * improve readability and fix typos --------- Co-authored-by: Jonhas Saul Colina <[email protected]> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Zain Mughal <[email protected]>
… to not include disclaimer regarding WIP notebooks (#57)
…ument ordering in the estimate methods to be more consistent
…m EstimateMetaData
…spective estimator tool
…en functions and classes -> nsteps
da31ff0 Commit revert
…rizationMetaData in estimate_trotter()
…to dev Merging local dev with remote
…lso fixed the convention with using objects as arguments and defaulting them to None
…f value_per_t_gate
…f value_per_t_gate
…si/qc-applications into feature/value_per_t_gate
…si/qc-applications into feature/value_per_t_gate
…si/qc-applications into feature/value_per_t_gate
…si/qc-applications into feature/value_per_t_gate
…si/qc-applications into feature/value_per_t_gate
…sts, but value_per_circuit or repetetions_per_application is undefined
…si/qc-applications into feature/value_per_t_gate
HotFix/Feature: added value_per_t_gate to the resource estimate
* Adding application 2: GSEE in RuCl notebook * Added RuCL GSEE script, modified RuCl dynamics script, updated RuCl pdf * Consolidated RuCl scripts to one with flag for mode, added changes to RuCl notebook. * Removed QPE cells * modified syntax, added csv file input for rucl script * updated rucl pdf * hot fix for rucl-application-2, in regards to init state, input data csv file, and upgrade pyliqtr version req * changes to syntax and to clean up code * add row and lattice size to circuit name for notebook * changes to make sure the graph is not being built more than once * changes to notebook for minimizing building rucl graph * notebook function call for ham gen * updated pdf for rucl
* new pyLIQTR version * qchem script cleanup * cleaned up value_per_t_gate and added analytical use case for gsee * made change to allow unique file name when performing a sweep * responded to issue of improper gate synth accuracy. pyLIQTR handles it differently depending on the function? * allow trotter to use use_analytical * fix typo * Updated pylint badge * doing 1e-10 rther than string * accidentally scaling num_qubits * Updated pylint badge * adding exotic phases script and moving print statement for generating trotterized subprocess gsee to AFTER we create circuit * changed field from value_per_circuit to value. Additionally, cleaned up some code to make sure we getting right value per t gate * fixed capitalization on ars --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
zain2864
requested changes
Jan 28, 2025
…ol sequence by KaTeX
zain2864
approved these changes
Jan 29, 2025
gsgrattan
reviewed
Jan 29, 2025
| @@ -193,8 +202,6 @@ | |||
| "print()\n", | |||
| "print('Tavis-Cummings Hamiltonian')\n", | |||
| "print(H_tavis_cummings)\n", | |||
| "#print(g_dicke.nodes)\n", | |||
| "#print(g_dicke.edges)\n", | |||
| "pos = get_node_attributes(g_dicke, 'pos')\n", | |||
| "labels = get_node_attributes(g_dicke, 'label')\n", | |||
| "draw(g_dicke, pos=pos, labels=labels, with_labels=True)\n", | |||
There was a problem hiding this comment.
Do we want to keep the commented out lines below?
notebooks/DickeModelExample.ipynb
Outdated
| "name": "stderr", | ||
| "output_type": "stream", | ||
| "text": [ | ||
| "/Users/gsgrattan/.conda/envs/qc-apps/lib/python3.11/site-packages/cotengra/hyperoptimizers/hyper.py:33: UserWarning: Couldn't import `kahypar` - skipping from default hyper optimizer and using basic `labels` method instead.\n", |
There was a problem hiding this comment.
Rerun to remove warning
notebooks/ExoticPhasesExample.ipynb
Outdated
| "name": "stderr", | ||
| "output_type": "stream", | ||
| "text": [ | ||
| "/Users/gsgrattan/.conda/envs/qc-apps/lib/python3.11/site-packages/cotengra/hyperoptimizers/hyper.py:33: UserWarning: Couldn't import `kahypar` - skipping from default hyper optimizer and using basic `labels` method instead.\n", |
There was a problem hiding this comment.
Rerun to remove warning
| @@ -184,7 +179,8 @@ | |||
| "outputs": [], | |||
| "source": [ | |||
| "molecular_hamiltonians = []\n", | |||
| "pathway = [1, 14, 15, 16, 24, 25, 26, 27]\n", | |||
| "# pathway = [1, 14, 15, 16, 24, 25, 26, 27]\n", | |||
There was a problem hiding this comment.
Should we remove the commented out values?
| "metadata": {}, | ||
| "outputs": [ | ||
| { | ||
| "name": "stdout", | ||
| "output_type": "stream", | ||
| "text": [ | ||
| "Total time to run through this notebook: 4212.176184124999\n" | ||
| "[juliapkg] Found dependencies: /Users/jonhas/envs/qca/lib/python3.12/site-packages/juliapkg/juliapkg.json\n", |
There was a problem hiding this comment.
Is it possible to suppress this output from julia?
| "\n", | ||
| "from qca.utils.utils import plot_histogram, gen_resource_estimate, re_as_json, EstimateMetaData\n", | ||
| "from qca.utils.utils import plot_histogram, gen_resource_estimate, re_as_json, QSPMetaData, TrotterMetaData,GSEEMetaData, circuit_estimate\n", | ||
| "from qca.utils.algo_utils import estimate_qsp, estimate_trotter, gsee_resource_estimation\n", | ||
| "from qca.utils.hamiltonian_utils import flatten_nx_graph, assign_hexagon_labels, pyliqtr_hamiltonian_to_openfermion_qubit_operator" | ||
| ] | ||
| }, |
There was a problem hiding this comment.
In the cell below there are 4 instances of \label for different equations, which is an undefined control sequence in KaTeX. They aren't referenced anywhere so it is safe to delete them to remove this error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is focused on merging features on Dev onto Main. This includes new features such as: