Expression testing and clean ups #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
harshangrjn
commented
Oct 13, 2020
•
harshangrjn
commented
- JuMP v0.21 build error issues fixed
- Compilation error #146 (MOI support fix)
- expression.jl clean up
- eval() removal where unnecessary Unnecessary use of eval in source code #153
- NL objective parsing fix for higher-order monomials: Error in convexification of monomials #104
- Issues Reenable test: Validation Test || AMP-CONV-FACET || basic solve || examples/nlp1.jl #151 Reenable test: Validation Test || PBT-AMP-TMC || basic solve || examples/nlp3.jl #150 addressed
- Drop support for all trigonometric related functions (both in src and testing)
- Drop support of expression parsing for generic integer variables in MINLPs (both in src and testing)
Codecov Report
@@ Coverage Diff @@
## master #154 +/- ##
==========================================
+ Coverage 75.23% 77.47% +2.24%
==========================================
Files 16 16
Lines 3359 3099 -260
==========================================
- Hits 2527 2401 -126
+ Misses 832 698 -134
Continue to review full report at Codecov.
|
blegat
reviewed
Oct 14, 2020
.travis.yml
Outdated
| @@ -4,10 +4,10 @@ os: | |||
| - linux | |||
| - osx | |||
| julia: | |||
| - 1.0 | |||
| - 1.5 | |||
There was a problem hiding this comment.
1.5 and 1 are the same thing, 1 links to the latest 1.x release
blegat
reviewed
Oct 14, 2020
test/runtests.jl
Outdated
| @@ -37,5 +36,5 @@ end | |||
| # Perform Tests | |||
| include("$(alpine_dir)/test/solver.jl") | |||
| include("$(alpine_dir)/test/expression.jl") | |||
| include("$(alpine_dir)/test/algorithm.jl") | |||
| include("$(alpine_dir)/test/utility.jl") | |||
| # include("$(alpine_dir)/test/algorithm.jl") | |||
There was a problem hiding this comment.
Why are these commented ? This is the cause of the coverage drop
There was a problem hiding this comment.
@blegat Good point! I am cleaning up tests individually. I just created the PR but still pushing updates to the PR. It should be uncommented in the newer commits.
blegat
reviewed
Oct 15, 2020
blegat
reviewed
Oct 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.