Added JUnit Testcases to the languagetool repo #9648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rootcause: Some of the Java files have 0% branch cause their respective JUnit files werent added. Fix: Added some JUnit testcases to increase the branch coverage overall.
danielnaber
requested changes
Nov 11, 2023
| @@ -0,0 +1,62 @@ | |||
| package org.languagetool; | |||
There was a problem hiding this comment.
Could you add the standard license header we use? (With your name as the copyright holder?)
|
|
||
| public class GlobalConfigTest { | ||
|
|
||
| /* This tests the equals method */ |
There was a problem hiding this comment.
The comment isn't really necessary
| // When both objects have the same server, their hash codes should be equal again. | ||
| assertEquals(config1.hashCode(), config2.hashCode()); | ||
|
|
||
| config1.setBeolingusFile(new File("file1")); |
There was a problem hiding this comment.
Could you use a different property? beoLingus isn't used anymore and might soon be removed
|
|
||
| @Test | ||
| public void testHashCode() { | ||
| // Create a SentenceRange object |
There was a problem hiding this comment.
These comments are not needed
| dateHelper = new YMDDateHelper(); | ||
| } | ||
|
|
||
| /* This checks the "parseData" method */ |
There was a problem hiding this comment.
Please remove the comments that don't provide value
Rootcause: Some design and/or implementation smells were not fixed. This was found as part while running the designite tool. Fix: Used refactoring techniques like Pull-up method, Introduce explaining variable, Decompose conditional, Extract method and rename variable to fix a few
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rootcause: Some of the Java files have 0% branch cause their respective JUnit files werent added.
Fix: Added some JUnit testcases to increase the branch coverage overall.