-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pt] Migrate spelling dictionaries to Morfologik format #9424
Conversation
e869757
to
46d0684
Compare
I restarted the CI process and this time it has worked, it seems. |
@SteVio89 the rule ID we had was not being underlined in red – I thought it was enough for it to contain |
Cannot merge until we work out how to get usage data from partial rollout. |
- add currency_symbols entity; - add currency rule to ignore spelling disambiguator rule group; - add test to morfologik speller tests.
After yesterday's test deployment:
I think it's safe to say we can merge this! Big success 🥳 Thanks @jaumeortola @maphjo @SteVio89 for the support with this endeavour! |
5 more percentage points is great! Thanks to everyone who has been working on this! |
Migrate PT dictionary to Morfologik
This PR:
hunspell/spelling.txt
tospelling.txt
;The work with curation of the dictionary source data was done in the
portuguese-pos-dict
repo.To do before merging
resource/pt/do_not_suggest.txt
.@jaumeortola , I've taken all the steps to release it. As far as I can see, it's live. But the tests still fail when trying to read the contents of the live repository. This part of it I have no idea about.
@danielnaber , you can already review the Java, I don't reckon it'll change.
@susanaboatto ... lol yeah there's a lot of stuff. Do have a look at the changes made to the disambiguator and the new files (
spelling.txt
,do_not_suggest.txt
, anddialect_alternations.txt
). All the other PT-specific changes are really made directly to the dictionary source data in the PT dictionary repo.Before merging, please let me squash this into something acceptable.