Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sv] Adding initial ngram support for Swedish #9042

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[sv] Adding initial ngram support for Swedish #9042

wants to merge 2 commits into from

Conversation

ljo
Copy link
Contributor

@ljo ljo commented Jul 25, 2023

  • Adding initial ngram support for Swedish.
  • Adding some initial infra and some rules with tests.

@danielnaber
Copy link
Member

The build failure is a problem with the build system. It should disappear if you sync your changes with the latest head.

@ljo ljo force-pushed the feature-sv-ngram-rules-and-tests branch from cf1172f to 3d674b1 Compare July 25, 2023 18:39
@ljo
Removing UpperCaseNgramRule and its tests in favour of the branch's m…
dca9d68 
…ain goal. Reworking it in a later PR to a generic super class with the other two implementations, or at lest German, but possibly also English (which is not used anyway from what I can tell).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielnaber danielnaber danielnaber requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ljo @danielnaber