-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cb changes 20241213 #11107
Cb changes 20241213 #11107
Changes from 5 commits
43d31d1
ef8fc4e
d1e4ba3
d85e839
61872b0
91e4e67
f29879a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -44195,6 +44195,11 @@ Stilempfehlungen | |
Preisetabelle/N | ||
3D-Secure-Verfahren/S | ||
Ivy-League-Universität | ||
Ivy-League-Uni/S | ||
Ivy-League-Student | ||
Ivy-League-Studentin | ||
Ivy-League-Studentinnen | ||
Ivy-League-Studenten | ||
Ivy-League-Universitäten | ||
Selbstabtönung | ||
Selbstabtönungen | ||
|
@@ -65432,6 +65437,24 @@ straßenbündig/A | |
Durchfahrtssperre/N | ||
Bøgseth/S | ||
AnnenMayKantereit/S | ||
syrischstämmig/A | ||
Dunkelflaute/N | ||
Neo-Angin/S #name | ||
privatinsolvent/A | ||
oberhell/A | ||
blitzkriegartig/A | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Consider alternative terminology for "blitzkriegartig". The term "blitzkriegartig" might be sensitive due to its historical connotations. Consider using alternatives like "blitzschnell" or "schlagartig" instead. |
||
umzugsfreudig/A | ||
Techanalyse/N | ||
Techanalyst | ||
Techanalystin | ||
Techanalystinnen | ||
Techanalysten | ||
Coxsackievirus | ||
Coxsackieviren | ||
Coxsackie-Virus | ||
Coxsackie-Viren | ||
Coxsackie-A-Virus | ||
Coxsackie-A-Viren | ||
Comment on lines
+65452
to
+65457
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🛠️ Refactor suggestion Ensure consistent hyphenation in virus terminology. The Coxsackievirus entries show inconsistent hyphenation:
Medical terminology should follow a consistent pattern. Consider standardizing all entries to use hyphens: -Coxsackievirus
-Coxsackieviren
+Coxsackie-Virus
+Coxsackie-Viren
|
||
ein_trainieren | ||
eintrainiert/P | ||
Mittelblockerposition | ||
|
Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
@@ -1831,7 +1831,7 @@ To ignore a remote rule match, set the <marker> so that it exactly covers the te | |||||||||||||||||||||||||||||||||
<rule> | ||||||||||||||||||||||||||||||||||
<pattern> | ||||||||||||||||||||||||||||||||||
<marker> | ||||||||||||||||||||||||||||||||||
<token regexp="yes">Barbarazweige?|obengenannt</token> | ||||||||||||||||||||||||||||||||||
<token regexp="yes">Barbarazweige?|obengenannt.*|privatinsolvent.*</token> | ||||||||||||||||||||||||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 💡 Codebase verification Based on the findings, I can now generate the final response: Add examples and documentation for new orthography space rule patterns The rule additions need proper documentation and examples:
Please:
🔗 Analysis chainVerify and document the new pattern additions The addition of "Barbarazweige|obengenannt.|privatinsolvent." to the pattern needs verification and documentation. Let's verify the usage of these terms in the codebase and documentation: Please:
Let me analyze the findings:
Let me check if there are any message/description files that might explain these rules: Let me check for any rule descriptions or messages that might explain the purpose of these additions: 🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Check for occurrences and documentation of the new terms
# Search for existing examples or documentation
rg -A 5 -B 5 "Barbarazweige|obengenannt|privatinsolvent"
# Search for any related test cases
fd -e "test.xml" -e "test.txt" -x rg "Barbarazweige|obengenannt|privatinsolvent" {}
Length of output: 8391 Script: #!/bin/bash
# Check for rule descriptions and messages
rg -A 5 -B 5 "AI_DE_GGEC_MISSING_ORTHOGRAPHY_SPACE" languagetool-language-modules/de/src/main/resources/org/languagetool/rules/de/
# Check if these terms appear in other rule files
fd -e xml -x rg "Barbarazweige?|obengenannt|privatinsolvent" {} languagetool-language-modules/de/src/main/resources/org/languagetool/rules/de/
Length of output: 66429 Script: #!/bin/bash
# Search for rule descriptions or messages containing these terms or rule ID
rg -B 5 -A 5 "AI_DE_GGEC_MISSING_ORTHOGRAPHY_SPACE" languagetool-language-modules/de/src/main/resources/org/languagetool/messages/
# Check for any XML comments near the rule definition
rg -B 10 -A 2 "AI_DE_GGEC_MISSING_ORTHOGRAPHY_SPACE" --type xml
Length of output: 2365 |
||||||||||||||||||||||||||||||||||
</marker> | ||||||||||||||||||||||||||||||||||
</pattern> | ||||||||||||||||||||||||||||||||||
<example correction=""><marker>Barbarazweige</marker> sind Zweige von Obstbäumen.</example> | ||||||||||||||||||||||||||||||||||
|
@@ -2000,6 +2000,13 @@ To ignore a remote rule match, set the <marker> so that it exactly covers the te | |||||||||||||||||||||||||||||||||
</pattern> | ||||||||||||||||||||||||||||||||||
<example correction="">Wir <marker>motzen</marker> heute.</example> | ||||||||||||||||||||||||||||||||||
</rule> | ||||||||||||||||||||||||||||||||||
<rule> | ||||||||||||||||||||||||||||||||||
<pattern> | ||||||||||||||||||||||||||||||||||
<token>sorry</token> | ||||||||||||||||||||||||||||||||||
<token>für</token> | ||||||||||||||||||||||||||||||||||
</pattern> | ||||||||||||||||||||||||||||||||||
<example correction=""><marker>Sorr für</marker> die Unannehmlichkeit.</example> | ||||||||||||||||||||||||||||||||||
</rule> | ||||||||||||||||||||||||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🛠️ Refactor suggestion Enhance the rule implementation for 'sorry für' pattern The rule implementation has several issues that need to be addressed:
Consider enhancing the rule with: <rule>
<pattern>
- <token>sorry</token>
- <token>für</token>
+ <token regexp="yes">sorry|sorr</token>
+ <token>für</token>
</pattern>
+ <suggestion>Entschuldigung für</suggestion>
<example correction="">Sorr für die Unannehmlichkeit.</example>
+ <example>Es tut mir leid für die Unannehmlichkeit.</example>
</rule> 📝 Committable suggestion
Suggested change
|
||||||||||||||||||||||||||||||||||
</rulegroup> | ||||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||||
<rulegroup name="" id="AI_DE_GGEC_REPLACEMENT_ORTHOGRAPHY_SPELL.*"> | ||||||||||||||||||||||||||||||||||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -10970,6 +10970,15 @@ hardcode | |
hardcoded | ||
DPA | ||
DPAs | ||
SOW | ||
SOWs | ||
XYZ | ||
xyz | ||
ABC | ||
abc | ||
PPHR | ||
DoP | ||
DoPs | ||
intl | ||
decontrol | ||
decontrols | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codebase verification
Review of medication trademark handling in German spelling dictionary
Based on the search results, I found several medication-related trademarks that should be consistently marked with #name:
These entries appear to be trademarks similar to Neo-Angin/S but currently lack the #name marker.
🔗 Analysis chain
Verify trademark handling for Neo-Angin.
The entry "Neo-Angin/S" is correctly marked with #name as it's a trademark. Consider if other branded medications in the dictionary should follow the same pattern.
Let me generate new shell scripts to specifically search for medication names in the German spelling dictionary:
This will help us identify if there are other medication names that should be marked with #name like Neo-Angin/S.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
Length of output: 69674
Script:
Length of output: 4010