Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump up French dict to v0.7 #10959

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Bump up French dict to v0.7 #10959

merged 1 commit into from
Oct 21, 2024

Conversation

p-goulart
Copy link
Collaborator

@p-goulart p-goulart commented Oct 21, 2024

This PR updates the LT POM to use the latest release of the French POS dictionary binaries (v0.7). Tests pass locally, we should be gucci.

cc @LucieSteib fyi

Summary by CodeRabbit

  • Chores
    • Updated the version of the french-pos-dict dependency to enhance compatibility and functionality.
    • Added comments for better management and documentation of dependencies.

Copy link
Contributor

coderabbitai bot commented Oct 21, 2024

Walkthrough

The changes in this pull request focus on updating the pom.xml file, specifically modifying the version of the french-pos-dict dependency from 0.6 to 0.7. Additionally, comments have been added to document compatibility checks and potential issues related to dependencies and plugins following these updates. This reflects an effort to maintain and manage project dependencies effectively.

Changes

File Change Summary
pom.xml Updated french-pos-dict version from 0.6 to 0.7 and added comments about dependency management and compatibility checks.

Possibly related PRs

Suggested reviewers

  • GillouLT

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)
pom.xml (1)

Line range hint 92-106: Review and address TODO comments in the Updated Block.

Several dependencies have been updated, and TODO comments have been added. Please review and address the following items:

  1. Check for errors on compile in wikipedia, dev, and rpm modules after updating org.sweble.wikitext.version to 3.1.9.
  2. Verify that disabling tests is intentional and necessary.
  3. Investigate the missing dependencies after the update: jopt-simple.jar, commons-jxpath.jar, and log4j.jar.
  4. Check compatibility for the updated org.apache.commons.commons-compress.version (1.27.1).
  5. Consider finding a replacement for edu.washington.cs.knowitall.opennlp.version as no update is available.
  6. Review the server and dev modules for potential updates related to org.mariadb.jdbc.version.

Please update the TODO comments with more specific information or create separate issues for each item to ensure they are properly tracked and addressed.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between f14ae84 and 181f94f.

📒 Files selected for processing (1)
  • pom.xml (1 hunks)
🧰 Additional context used
🔇 Additional comments (1)
pom.xml (1)

223-223: LGTM: French POS dictionary version updated as intended.

The update from version 0.6 to 0.7 of the French POS dictionary aligns with the PR objective. This change should improve the French language support in LanguageTool.

To ensure this update doesn't introduce any unexpected issues, please run the following verification script:

✅ Verification successful

@p-goulart p-goulart merged commit d59ad5c into master Oct 21, 2024
5 checks passed
@p-goulart p-goulart deleted the fr/dict/0.7 branch October 21, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants