-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump up French dict to v0.7 #10959
Bump up French dict to v0.7 #10959
Conversation
WalkthroughThe changes in this pull request focus on updating the Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
pom.xml (1)
Line range hint
92-106
: Review and address TODO comments in the Updated Block.Several dependencies have been updated, and TODO comments have been added. Please review and address the following items:
- Check for errors on compile in wikipedia, dev, and rpm modules after updating
org.sweble.wikitext.version
to 3.1.9.- Verify that disabling tests is intentional and necessary.
- Investigate the missing dependencies after the update: jopt-simple.jar, commons-jxpath.jar, and log4j.jar.
- Check compatibility for the updated
org.apache.commons.commons-compress.version
(1.27.1).- Consider finding a replacement for
edu.washington.cs.knowitall.opennlp.version
as no update is available.- Review the server and dev modules for potential updates related to
org.mariadb.jdbc.version
.Please update the TODO comments with more specific information or create separate issues for each item to ensure they are properly tracked and addressed.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- pom.xml (1 hunks)
🧰 Additional context used
🔇 Additional comments (1)
pom.xml (1)
223-223
: LGTM: French POS dictionary version updated as intended.The update from version 0.6 to 0.7 of the French POS dictionary aligns with the PR objective. This change should improve the French language support in LanguageTool.
To ensure this update doesn't introduce any unexpected issues, please run the following verification script:
✅ Verification successful
This PR updates the LT POM to use the latest release of the French POS dictionary binaries (
v0.7
). Tests pass locally, we should be gucci.cc @LucieSteib fyi
Summary by CodeRabbit
french-pos-dict
dependency to enhance compatibility and functionality.