Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DispatchDoctor.jl to testing #39

Open
wants to merge 26 commits into
base: main
Choose a base branch
from
Open

Add DispatchDoctor.jl to testing #39

wants to merge 26 commits into from

Conversation

langfzac
Copy link
Owner

Use DispatchDoctor.jl to check type stability during tests

@ericagol
Copy link
Collaborator

It looks like this may not be compatible with the older version of Julia?

@langfzac
Copy link
Owner Author

It looks like this may not be compatible with the older version of Julia?

Actually, it's the latest version (the "Julia 1" tests are "latest version 1.x.x"). Looks like the issue is the plotting code, which I'll need to stare at a bit longer. I should move that code into a proper extension module anyways, so maybe I'll do that and see if that fixes things. I'm also not too concerned about the performance of the plotting code, so I could just keep the type stability checks from running on it, at least for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants