-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps-dev): bump ruff from 0.5.7 to 0.7.1 #976
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Disclaimer: Experimental PR review
PR Summary
This PR updates the ruff linting dependency from v0.5.7 to v0.7.1, introducing breaking changes that require attention in the linting configuration.
- Updated ruff version constraint in
pyproject.toml
from<0.6.0
to<0.8.0
- Breaking change:
lint.allow-unused-imports
setting has been removed, needs migration tolint.pyflakes.allow-unused-imports
- Both
ruff.toml
andci.ruff.toml
may need updates to handle breaking changes in pytest rules PT001/PT023 - CI workflow uses
chartboost/ruff-action@v1
which needs compatibility verification with ruff v0.7.1
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
Bumps [ruff](https://github.com/astral-sh/ruff) from 0.5.7 to 0.7.1. - [Release notes](https://github.com/astral-sh/ruff/releases) - [Changelog](https://github.com/astral-sh/ruff/blob/main/CHANGELOG.md) - [Commits](astral-sh/ruff@0.5.7...0.7.1) --- updated-dependencies: - dependency-name: ruff dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
5fed121
to
ca877e7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Disclaimer: Experimental PR review
PR Summary
(updates since last review)
This PR continues to evolve with significant changes around data masking functionality being added across the codebase. Here's a summary of the key changes:
Adds comprehensive data masking functionality to protect sensitive information:
- Added new
MaskFunction
protocol type intypes/__init__.py
defining the interface for data masking functions - Implemented masking support in
TaskManager
with in-place masking of event input/output fields - Added mask parameter propagation through
LangfuseBaseCallbackHandler
,LangchainCallbackHandler
, andLlamaIndexInstrumentor
classes - Added test coverage in
test_core_sdk.py
to verify masking behavior for both successful and error cases - Improved error handling in OpenAI integration by adding null checks for usage object serialization
The changes maintain backward compatibility since the masking functionality is optional, while providing a robust way to protect sensitive data before sending to the Langfuse backend.
15 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings | Greptile
@@ -35,7 +35,7 @@ lark = "^1.1.7" | |||
pytest-asyncio = ">=0.21.1,<0.24.0" | |||
pytest-httpserver = "^1.0.8" | |||
boto3 = "^1.28.59" | |||
ruff = ">=0.1.8,<0.6.0" | |||
ruff = ">=0.1.8,<0.8.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: if using lint.allow-unused-imports in ruff config, must migrate to lint.pyflakes.allow-unused-imports
Bumps ruff from 0.5.7 to 0.7.1.
Release notes
Sourced from ruff's releases.
... (truncated)
Changelog
Sourced from ruff's changelog.
... (truncated)
Commits
337af83
Bump version to 0.7.1 (#13913)113ce84
Fixnormalize
arguments whenfstring_formatting
is disabled (#13910)7272f83
Fix preview style name incan_omit_parentheses
to is_f_string_formatting_en...3eb4546
[red-knot] Format mdtest Python snippets more concisely (#13905)77ae0cc
[red-knot] Infer subscript expression types for bytes literals (#13901)73ee72b
Join implicit concatenated strings when they fit on a line (#13663)e402e27
Use referencial equality intraversal
helper methods (#13895)de4181d
Remove "default" remark fromruff check
(#13900)2c57c2d
[red-knot] Type narrowing forisinstance
checks (#13894)72c18c8
Fix E221 and E222 to flag missing or extra whitespace around==
operator (#...You can trigger a rebase of this PR by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)