Compress create feedback #1452
Merged
Compress create feedback #1452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angus-langchain
force-pushed
the
angus/compress-create-feedback
branch
2 times, most recently
from
953d0d7 to
79e1709
Compare
angus-langchain
force-pushed
the
angus/compress-create-feedback
branch
from
79e1709 to
478d1a2
Compare
hinthornw
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Compress feedback along with runs using the same compression buffer and background thread
Changes
num_refsto account for compression bg thread.Tests
Tested locally to ensure feedback ingest works with and without compression
Added unit tests for feedback ingest with compression