surface mime type when passing attachments to user #1409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacoblee93
reviewed
Jan 11, 2025
| @@ -2770,6 +2770,7 @@ export class Client implements LangSmithTracingClientInterface { | |||
| (acc, [key, value]) => { | |||
| acc[key.slice("attachment.".length)] = { | |||
| presigned_url: value.presigned_url, | |||
| mime_type: value.mime_type || undefined, | |||
There was a problem hiding this comment.
You don't need || undefined, just value.mime_type
jacoblee93
reviewed
Jan 11, 2025
| @@ -40,6 +40,10 @@ test("evaluate can handle examples with attachments", async () => { | |||
| const expectedData = new Uint8Array( | |||
| Buffer.from("fake image data for testing") | |||
| ); | |||
| const attachmentMimeType = config?.attachments?.["image"].mime_type; | |||
There was a problem hiding this comment.
config?.attachments?.image.mime_type; is more conventional
For JS you only use box notation like that for things that have characters that can be represented inline e.g. if you were to do:
config?.attachments?.["foo-bar"].mime_type;
agola11
approved these changes
Jan 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.