Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libs: add sambanova-lagchain integration package #29417

Merged
merged 12 commits into from
Jan 27, 2025
Merged

libs: add sambanova-lagchain integration package #29417

merged 12 commits into from
Jan 27, 2025

Conversation

jhpiedrahitao
Copy link
Contributor

  • Description:: Add sambanova-langchain integration package as suggested in previous PRs

@jhpiedrahitao jhpiedrahitao requested a review from efriis as a code owner January 24, 2025 20:46
@vercel Vercel
Copy link

vercel bot commented Jan 24, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchain ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 27, 2025 8:34pm

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Jan 24, 2025
@dosubot dosubot bot added langchain Related to the langchain package 🤖:docs Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder labels Jan 24, 2025
@jhpiedrahitao
Copy link
Contributor Author

Hi @efriis

following your suggestion in previous PRs we are adding the sambanova-langchain integration package

#29070 (comment)
#28025 (comment)

cc @ccurme

efriis
efriis reviewed Jan 24, 2025
View reviewed changes
Copy link
Member

@efriis efriis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! Any chance you could add the @deprecated decorators to the community versions, with e.g. alternative_import="langchain_sambanova.ChatSambaNovaCloud?

since should be 0.3.16 (next community version)
removal should be 1.0

@efriis efriis self-assigned this Jan 24, 2025
@jhpiedrahitao
Copy link
Contributor Author

thanks! Any chance you could add the @deprecated decorators to the community versions, with e.g. alternative_import="langchain_sambanova.ChatSambaNovaCloud?

since should be 0.3.16 (next community version) removal should be 1.0

@efriis done!

ccurme
ccurme approved these changes Jan 27, 2025
View reviewed changes
Copy link
Collaborator

@ccurme ccurme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

docs/docs/integrations/chat/sambanova.ipynb
@@ -546,7 +545,7 @@
"source": [
"## API reference\n",
"\n",
"For detailed documentation of all ChatSambaNovaCloud features and configurations head to the API reference: https://python.langchain.com/api_reference/community/chat_models/langchain_community.chat_models.sambanova.ChatSambaNovaCloud.html"
"For detailed documentation of all ChatSambaNovaCloud features and configurations head to the API reference: https://python.langchain.com/api_reference/sambanova/chat_models/langchain_sambanova.ChatSambaNovaCloud.html"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

link 404s (we don't build API references for external packages)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ccurme should we only remove the cell? is there any way to get API reference included as all the other provider integrations?

@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Jan 27, 2025
@ccurme ccurme enabled auto-merge (squash) January 27, 2025 20:25
@ccurme ccurme merged commit 3b886cd into langchain-ai:master Jan 27, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efriis efriis efriis left review comments

@ccurme ccurme ccurme approved these changes

Assignees

@efriis efriis

Labels
🤖:docs Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder langchain Related to the langchain package lgtm PR looks good. Use to confirm that a PR is ready for merging. size:L This PR changes 100-499 lines, ignoring generated files.
Projects
PR Reviews
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jhpiedrahitao @efriis @ccurme