Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed similarity search with score error #29407 #29413

Merged
merged 3 commits into from
Jan 27, 2025

Conversation

Anash3
Copy link
Contributor

@Anash3 Anash3 commented Jan 24, 2025

Description: Fix TypeError in AzureSearch similarity_search_with_score by removing search_type from kwargs before passing to underlying requests.

This resolves issue #29407 where search_type was being incorrectly passed through to Session.request().
Issue: #29407

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jan 24, 2025
Copy link

vercel bot commented Jan 24, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Jan 27, 2025 8:30pm

@dosubot dosubot bot added community Related to langchain-community Ɑ: vector store Related to vector store module 🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature labels Jan 24, 2025
@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Jan 27, 2025
@ccurme ccurme enabled auto-merge (squash) January 27, 2025 20:30
@ccurme ccurme merged commit aba1fd0 into langchain-ai:master Jan 27, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature community Related to langchain-community lgtm PR looks good. Use to confirm that a PR is ready for merging. size:XS This PR changes 0-9 lines, ignoring generated files. Ɑ: vector store Related to vector store module
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants