core: Add ruff rules PT (pytest) #29381
Open
+399
−243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
dosubot
bot
added
size:XL
cbornet
commented
Jan 23, 2025
| @@ -95,6 +95,7 @@ async def test_async_batch_size(messages: list, messages_2: list) -> None: | |||
| assert (cb.traced_runs[0].extra or {}).get("batch_size") == 1 | |||
|
|
|||
|
|
|||
| @pytest.mark.xfail(reason="This test is failing due to a bug in the testing code") | |||
There was a problem hiding this comment.
The linter found an issue in the test code here.
It was not seen before because eval_response was never executed.
cbornet
commented
Jan 23, 2025
| @@ -93,6 +93,7 @@ async def test_async_batch_size() -> None: | |||
| assert (cb.traced_runs[0].extra or {}).get("batch_size") == 1 | |||
|
|
|||
|
|
|||
| @pytest.mark.xfail(reason="This test is failing due to a bug in the testing code") | |||
There was a problem hiding this comment.
The linter found an issue in the test code here.
It was not seen before because eval_response was never executed.
cbornet
commented
Jan 23, 2025
| template=[graph_creator_content1, graph_creator_content2], | ||
| input_variables=["variables"], | ||
| partial_variables={"variables": "foo"}, | ||
| ) | ||
| graph_analyst_template.format(variables="foo") |
There was a problem hiding this comment.
This call was not executed.
cbornet
force-pushed
the
ruff-core-pt
branch
3 times, most recently
from
d637934 to
2a88aca
Compare
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://docs.astral.sh/ruff/rules/#flake8-pytest-style-pt