core: Add ruff rules RUF #29353
Open
core: Add ruff rules RUF #29353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
dosubot
bot
added
size:L
cbornet
commented
Jan 22, 2025
| loop.create_task(coro) | ||
| # TODO: Fix RUF006 - this task should have a reference | ||
| # and be awaited somewhere | ||
| loop.create_task(coro) # noqa: RUF006 |
There was a problem hiding this comment.
There is something wrong here.
Do you have guidance in how to fix ? Or should I open an issue ?
cbornet
commented
Jan 22, 2025
| select = [ "ASYNC", "B", "C4", "COM", "DJ", "E", "EM", "EXE", "F", "FLY", "FURB", "I", "ICN", "INT", "LOG", "N", "NPY", "PD", "PIE", "Q", "RSE", "S", "SIM", "SLOT", "T10", "T201", "TID", "UP", "W", "YTT",] | ||
| ignore = [ "COM812", "UP007", "S110", "S112",] | ||
| select = [ "ASYNC", "B", "C4", "COM", "DJ", "E", "EM", "EXE", "F", "FLY", "FURB", "I", "ICN", "INT", "LOG", "N", "NPY", "PD", "PIE", "Q", "RSE", "RUF", "S", "SIM", "SLOT", "T10", "T201", "TID", "UP", "W", "YTT",] | ||
| ignore = [ "COM812", "UP007", "RUF010", "RUF012", "S110", "S112",] |
There was a problem hiding this comment.
RUF010 temporarily ignored because it would create lots of conflicts for the PR with #29334
RUF012 ignored because it doesn't play well with Pydantic
cbornet
force-pushed
the
ruff-core-ruf
branch
from
668c55a to
329e995
Compare
cbornet
force-pushed
the
ruff-core-ruf
branch
from
329e995 to
bc47278
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://docs.astral.sh/ruff/rules/#ruff-specific-rules-ruf