core: Add ruff rules for Pylint PLC (Convention) and PLE (Errors) #29286
+51
−57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
dosubot
bot
added
size:M
cbornet
force-pushed
the
ruff-core-plc
branch
2 times, most recently
from
d20fd3b to
3a291b1
Compare
cbornet
changed the title
eyurtsev
reviewed
Jan 20, 2025
| @@ -6,7 +6,6 @@ | |||
| from collections import deque | |||
| from collections.abc import AsyncIterator, Iterator | |||
| from io import StringIO | |||
| from typing import Optional as Optional | |||
There was a problem hiding this comment.
These were intentionally due to pydantic forward references not being properly resolved. Do you know if the underlying issue is resolved? We'd potentially be seeing issues when running langchain or langchain community unit tests
There was a problem hiding this comment.
The tests pass, so I guess it's OK ?
Do you have the pydantic reference issue ?
cbornet
force-pushed
the
ruff-core-plc
branch
2 times, most recently
from
f49f83c to
a334336
Compare
cbornet
force-pushed
the
ruff-core-plc
branch
from
a334336 to
b7ef6be
Compare
dosubot
bot
added
size:L
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://docs.astral.sh/ruff/rules/#pylint-pl