core: Add ruff rules ANN (type annotations) #29271
Open
+52
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
cbornet
force-pushed
the
ruff-core-ann
branch
from
286dcce to
c0427b3
Compare
cbornet
commented
Jan 17, 2025
| if instance is not None or owner is not None: | ||
| emit_warning() | ||
| if self.fget is None: |
There was a problem hiding this comment.
Other possibility could be to call super().__get__ ?
dosubot
bot
added
size:M
cbornet
force-pushed
the
ruff-core-ann
branch
from
c0427b3 to
6b05ffa
Compare
eyurtsev
approved these changes
Jan 20, 2025
| @@ -2186,7 +2186,7 @@ class Foo(BaseModelV2): | |||
| ) | |||
|
|
|||
| @tool(args_schema=Foo) | |||
| def foo(x): # type: ignore[no-untyped-def] | |||
| def foo(x: list[int]) -> list[int]: | |||
There was a problem hiding this comment.
Probably reasonable to not update this type signature -- this test is attempting to verify that all the information is getting picked up from the args_schema?
There was a problem hiding this comment.
Indeed!
Done in 454b292
dosubot
bot
added
the
lgtm
cbornet
force-pushed
the
ruff-core-ann
branch
2 times, most recently
from
454b292 to
eda139c
Compare
cbornet
force-pushed
the
ruff-core-ann
branch
from
eda139c to
d0358e9
Compare
cbornet
force-pushed
the
ruff-core-ann
branch
from
d0358e9 to
04dfa99
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://docs.astral.sh/ruff/rules/#flake8-annotations-ann
The interest compared to only mypy is that ruff is very fast at detecting missing annotations.
ANN101 and ANN102 are deprecated so we ignore them
ANN401 (no Any type) ignored to be in sync with mypy config