Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Remove redundant "%" #29205

Merged
merged 1 commit into from
Jan 17, 2025
Merged

docs: Remove redundant "%" #29205

merged 1 commit into from
Jan 17, 2025

Conversation

junhe
Copy link
Contributor

@junhe junhe commented Jan 14, 2025

Before this commit, the copied command can't be used directly.

@junhe
Remove redundant "%"
a293e38 
Before this commit, the copied command can't be used directly.
@vercel Vercel
Copy link

vercel bot commented Jan 14, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchain ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 14, 2025 4:45pm

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. 🤖:docs Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder labels Jan 14, 2025
ccurme
ccurme reviewed Jan 14, 2025
View reviewed changes
Copy link
Collaborator

@ccurme ccurme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you clarify the issue here? Running this in a Jupyter notebook should run the pip install.

@ccurme ccurme closed this Jan 14, 2025
@junhe
Copy link
Contributor Author

junhe commented Jan 15, 2025

Can you clarify the issue here? Running this in a Jupyter notebook should run the pip install.

It was just that there is a redundant %. This is unwanted because, for example, when users click "Copy" button, the % will also be copied, which makes the command unable to run directly in the terminal.

@ccurme ccurme reopened this Jan 17, 2025
@ccurme ccurme enabled auto-merge (squash) January 17, 2025 14:29
@ccurme ccurme merged commit f022613 into langchain-ai:master Jan 17, 2025
24 checks passed
@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccurme ccurme ccurme approved these changes

Assignees
No one assigned
Labels
🤖:docs Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder lgtm PR looks good. Use to confirm that a PR is ready for merging. size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
PR Reviews
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@junhe @ccurme