Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chroma[patch]: fix bug #28538

Merged
merged 2 commits into from
Dec 5, 2024
Merged

chroma[patch]: fix bug #28538

merged 2 commits into from
Dec 5, 2024

Conversation

ccurme
Copy link
Collaborator

@ccurme ccurme commented Dec 5, 2024

Fix bug introduced in #27995

If all document IDs are "", the chroma SDK will raise

DuplicateIDError: Expected IDs to be unique

Caught by docs tests, but added a test to langchain-chroma as well.

Copy link

vercel bot commented Dec 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Dec 5, 2024 3:31pm

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Dec 5, 2024
@ccurme ccurme enabled auto-merge (squash) December 5, 2024 15:31
@dosubot dosubot bot added Ɑ: vector store Related to vector store module 🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature labels Dec 5, 2024
@ccurme ccurme merged commit 8f9b3b7 into master Dec 5, 2024
19 checks passed
@ccurme ccurme deleted the cc/fix_chroma branch December 5, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature size:S This PR changes 10-29 lines, ignoring generated files. Ɑ: vector store Related to vector store module
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant