Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

community: tongyi multimodal response format fix to support langchain #28212

Closed
wants to merge 3 commits into from

Conversation

achenglike
Copy link
Contributor

  • Description: The multimodal(tongyi) response format "message": {"role": "assistant", "content": [{"text": "图像"}]}}]} is not compatible with LangChain.
  • Dependencies: No

The multimodal(tongyi) response format "message": {"role": "assistant", "content": [{"text": "图像"}]}}]} is not compatible with LangChain.
fix: code line too long
tongyi.py fix lint error
Copy link

vercel bot commented Nov 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Nov 19, 2024 7:52am

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. community Related to langchain-community 🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature labels Nov 19, 2024
Copy link
Member

@efriis efriis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

at a minimum let's make this a hidden _fix... method so it doesn't show in the api docs. Can we handle this inline instead though? I feel like message parsing should maybe also happen in other places than streaming...

@achenglike achenglike closed this by deleting the head repository Dec 10, 2024
@achenglike
Copy link
Contributor Author

achenglike commented Dec 10, 2024

at a minimum let's make this a hidden _fix... method so it doesn't show in the api docs. Can we handle this inline instead though? I feel like message parsing should maybe also happen in other places than streaming...

Thank you for your advice. I have created a new PR #28645 (using inline). By the way, I only encountered this issue with the streaming implementation, as Tongyi uses different packages for streaming and one-shot responses.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature community Related to langchain-community size:S This PR changes 10-29 lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants