Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

community[patch]: support numpy2 #28184

Merged
merged 10 commits into from
Nov 27, 2024
Merged

Conversation

ghinch
Copy link
Contributor

@ghinch ghinch commented Nov 18, 2024

Follows on from #27991, updates the langchain-community package to support numpy 2 versions

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Nov 18, 2024
Copy link

vercel bot commented Nov 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Nov 27, 2024 4:00pm

@dosubot dosubot bot added the community Related to langchain-community label Nov 18, 2024
@ccurme ccurme self-assigned this Nov 26, 2024
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Nov 26, 2024
Copy link
Collaborator

@ccurme ccurme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this!

Comment on lines -140 to -141
# community extended test resolution in 3.12 is slow
# even in uv
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@efriis FYI removing this cap because dependency resolution appears to go reasonably fast in 3.12 now.

@@ -55,7 +55,6 @@ openai<2
openapi-pydantic>=0.3.2,<0.4
oracle-ads>=2.9.1,<3
oracledb>=2.2.0,<3
outlines[test]>=0.1.0,<0.2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified that we don't lose any coverage with this as we're not decorating any tests with @pytest.mark.requires for outlines.

Extended tests run before removal: https://github.com/langchain-ai/langchain/actions/runs/12053796858/job/33610328589

After removal: https://github.com/langchain-ai/langchain/actions/runs/12053978122/job/33610948323?pr=28184

@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Nov 27, 2024
@ccurme ccurme merged commit 5141f25 into langchain-ai:master Nov 27, 2024
83 checks passed
@oborovyilpnu
Copy link

Hi. Thank you for making such a change. Can I ask you to make a new release of langchain-community with this change?

@ccurme
Copy link
Collaborator

ccurme commented Dec 2, 2024

Hi. Thank you for making such a change. Can I ask you to make a new release of langchain-community with this change?

Released in langchain-community 0.3.9 today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Related to langchain-community lgtm PR looks good. Use to confirm that a PR is ready for merging. size:S This PR changes 10-29 lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants