Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<Community>: Improve tidb vector notebook #18772

Conversation

IANTHEREAL
Copy link
Contributor

This PR introduces two changes aimed at enhancing the readability and maintainability of the tidb vector notebook:

  • Variable Naming Improvements: We've updated variable names to be more descriptive and intuitive, making it easier for users to understand the code's functionality at a glance.
  • Removal of Redundant Content

Copy link

vercel bot commented Mar 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchain ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 8, 2024 2:33am

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. Ɑ: vector store Related to vector store module 🤖:docs Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder labels Mar 8, 2024
@IANTHEREAL
Copy link
Contributor Author

This is a minor oversight from merging the .
@baskaryan PTAL, and Thank you.

@IANTHEREAL IANTHEREAL closed this Mar 8, 2024
@IANTHEREAL IANTHEREAL deleted the tidb-vector-notebook-improvement branch March 8, 2024 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖:docs Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder size:M This PR changes 30-99 lines, ignoring generated files. Ɑ: vector store Related to vector store module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant