core[minor]: Add Runnable.batch_as_completed #17603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:M
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
dosubot
bot
added
the
🤖:improvement
eyurtsev
approved these changes
Feb 16, 2024
dosubot
bot
added
the
lgtm
eyurtsev
changed the title
eyurtsev
reviewed
Feb 16, 2024
| *, | ||
| return_exceptions: bool = False, | ||
| **kwargs: Optional[Any], | ||
| ) -> AsyncIterator[Tuple[Input, Output]]: |
There was a problem hiding this comment.
Do we need this to be AsyncIterator[Tuple[int, Input, Output]]?
Duplicated Input, Output but different configs
There was a problem hiding this comment.
like index in input array?
There was a problem hiding this comment.
in that case I'd actually prefer to not return the input at all, just index and output, wdyt?
nfcampos
force-pushed
the
nc/15feb/batch-as-completed
branch
from
a550b4d to
5a081cd
Compare
dosubot
bot
added
size:L
baskaryan
approved these changes
Mar 13, 2024
gkorland
pushed a commit
to FalkorDB/langchain
that referenced
this pull request
Mar 30, 2024
This PR adds `batch as completed` method to the standard Runnable interface. It takes in a list of inputs and yields the corresponding outputs as the inputs are completed.
hinthornw
pushed a commit
that referenced
this pull request
Apr 26, 2024
This PR adds `batch as completed` method to the standard Runnable interface. It takes in a list of inputs and yields the corresponding outputs as the inputs are completed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
batch as completedmethod to the standard Runnable interface. It takes in a list of inputs and yields the corresponding outputs as the inputs are completed.