Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update documentation for RunnableWithMessageHistory #17602

Merged
merged 4 commits into from
Feb 16, 2024

Conversation

ccurme
Copy link
Collaborator

@ccurme ccurme commented Feb 15, 2024

I don't have access to an Anthropic API key so I updated things to use OpenAI. Let me know if you'd prefer another provider.

@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Feb 15, 2024
Copy link

vercel bot commented Feb 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchain ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 15, 2024 11:55pm

@dosubot dosubot bot added Ɑ: lcel Related to LangChain Expression Language (LCEL) 🔌: openai Primarily related to OpenAI integrations 🤖:docs Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder labels Feb 15, 2024
@eyurtsev
Copy link
Collaborator

Awesome!

Two things small comments:

  1. The high level orgnaization focuses on in memory vs. persistent storage:

image

Could we update the headers to highlight the API more prominently.

Users will likely be looking at this to figure out how to wrap a runnable and understand the API, and only afterwards worry about which storage to use (memory vs. redis etc.)

  1. Would you mind showing off an example with streaming? (I think you could throw in a sleep into the store itself when doing add_messages to show that streaming will not be blocked.)

@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Feb 16, 2024
@eyurtsev
Copy link
Collaborator

Going to merge existing changes, can follow up if you'd like with changes suggested by comment!

@eyurtsev eyurtsev merged commit 0b33abc into langchain-ai:master Feb 16, 2024
7 checks passed
@ccurme ccurme deleted the cc/message_history branch February 19, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖:docs Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder Ɑ: lcel Related to LangChain Expression Language (LCEL) lgtm PR looks good. Use to confirm that a PR is ready for merging. 🔌: openai Primarily related to OpenAI integrations size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants