Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

community: support UAE sentence embeddings #15134

Closed
wants to merge 4 commits into from
Closed

community: support UAE sentence embeddings #15134

wants to merge 4 commits into from

Conversation

SeanLee97
Copy link

  • Description: support loading the current SOTA sentence embeddings WhereIsAI/UAE in langchain.
  • Dependencies: angle_emb
  • Twitter handle: @xmlee97

@vercel Vercel
Copy link

vercel bot commented Dec 25, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Jan 31, 2024 1:10am

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. Ɑ: embeddings Related to text embedding models module 🤖:enhancement A large net-new component, integration, or chain. Use sparingly. The largest features labels Dec 25, 2023
@SeanLee97
Copy link
Author

@hwchase17 Could you help review this PR? thanks!

@hwchase17
Copy link
Contributor

needs to be merged with master

@SeanLee97
Copy link
Author

hi @hwchase17 , I've solved the conflicts.

hwchase17
hwchase17 approved these changes Jan 2, 2024
View reviewed changes
Copy link
Contributor

@hwchase17 hwchase17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks

@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Jan 2, 2024
@SeanLee97
Copy link
Author

When can this branch be merged?

@hwchase17
Copy link
Contributor

@SeanLee97 - lint is failing and I do not have permissions to push to this branch

plz either fix lint or give me permissions to push to this branch and I can do that

@hwchase17 hwchase17 closed this Jan 30, 2024
@baskaryan baskaryan reopened this Jan 30, 2024
@SeanLee97
Copy link
Author

@SeanLee97 - lint is failing and I do not have permissions to push to this branch

plz either fix lint or give me permissions to push to this branch and I can do that

hi @hwchase17 , I've granted you the permission. Could you help to push it? many thanks

@Tejash-Shah
Copy link

Hi, is there any update on this?
Would like to use UAE through langchain

baskaryan
baskaryan reviewed Feb 21, 2024
View reviewed changes
libs/community/langchain_community/embeddings/__init__.py
@@ -11,7 +11,7 @@
"""


import logging
import logging # NOQA
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete comment

@zerodrift
Copy link

Any updates?

@baskaryan
Copy link
Collaborator

seems to have some lint issues, run

cd libs/community
make format
make lint

to see if that fixes them

@ccurme ccurme added the community Related to langchain-community label Jun 18, 2024
@efriis
Copy link
Member

efriis commented Dec 10, 2024

wow old one! At this time, we're not recommending custom subclasses of Huggingface implementations for specific models because they're generic. Additionally the integration is managed in https://github.com/langchain-ai/langchain-huggingface instead of here! The langchain_huggingface.HuggingFaceEmbeddings version will have the latest and greatest compatibility

@efriis efriis closed this Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baskaryan baskaryan baskaryan approved these changes

@hwchase17 hwchase17 hwchase17 approved these changes

Assignees

@hwchase17 hwchase17

Labels
community Related to langchain-community Ɑ: embeddings Related to text embedding models module 🤖:enhancement A large net-new component, integration, or chain. Use sparingly. The largest features lgtm PR looks good. Use to confirm that a PR is ready for merging. size:M This PR changes 30-99 lines, ignoring generated files.
Projects
PR Reviews
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@SeanLee97 @hwchase17 @Tejash-Shah @zerodrift @baskaryan @efriis @ccurme