Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update with new VertexAIModelGarden output format #14444

Closed
wants to merge 1 commit into from

Conversation

shikanime
Copy link
Contributor

@shikanime shikanime commented Dec 8, 2023

On December 1st, the Google Cloud Vertex AI Model Garden models runtime received an update in the form of Prompt:\n\t{prompt}\nOutput:\n\t{prompt} and now streams tokens throughout the second level list.

This change will break the current behavior of your applications if adequate fixes are not applied.
We are promoting these changes based on our experiences with LLaMA, Falcon, Mistral, and additional models that are distributed directly by Vertex AI Model Garden.

Probably fixes #13370 #10012

Copy link

vercel bot commented Dec 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Dec 13, 2023 9:56am

@shikanime shikanime force-pushed the pr14444 branch 15 times, most recently from aae5a65 to f131a58 Compare December 8, 2023 16:22
@shikanime shikanime marked this pull request as ready for review December 10, 2023 02:44
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. Ɑ: models Related to LLMs or chat model modules 🤖:improvement Medium size change to existing code to handle new use-cases labels Dec 10, 2023
@shikanime shikanime force-pushed the pr14444 branch 5 times, most recently from 297083e to cf42493 Compare December 11, 2023 17:51
@shikanime
Copy link
Contributor Author

Vertex AI Model Garden have some wild changes depending on how you run it, I made few fix for specific ones at https://github.com/shikanime/langchain-vertexai-extended.git

@baskaryan baskaryan reopened this Jan 30, 2024
@javadyaali
Copy link

Thanks @shikanime 💯

@baskaryan baskaryan added the 🔌: google Primarily related to Google GenAI or VertexAI integrations label Feb 21, 2024
@efriis
Copy link
Member

efriis commented Mar 19, 2024

Should be against the https://github.com/langchain-ai/langchain-google repo instead!

@efriis efriis closed this Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔌: google Primarily related to Google GenAI or VertexAI integrations 🤖:improvement Medium size change to existing code to handle new use-cases Ɑ: models Related to LLMs or chat model modules size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VertexAIModelGarden _generate method not in sync with VertexAI API
5 participants