Skip to content

Commit

Permalink
core[patch]: make get_all_basemodel_annotations public (#27761)
Browse files Browse the repository at this point in the history
  • Loading branch information
baskaryan authored Oct 30, 2024
1 parent 94ea950 commit 5d33732
Show file tree
Hide file tree
Showing 3 changed files with 24 additions and 17 deletions.
8 changes: 4 additions & 4 deletions libs/core/langchain_core/tools/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -449,7 +449,7 @@ def args(self) -> dict:
def tool_call_schema(self) -> type[BaseModel]:
full_schema = self.get_input_schema()
fields = []
for name, type_ in _get_all_basemodel_annotations(full_schema).items():
for name, type_ in get_all_basemodel_annotations(full_schema).items():
if not _is_injected_arg_type(type_):
fields.append(name)
return _create_subset_model(
Expand Down Expand Up @@ -962,7 +962,7 @@ def _is_injected_arg_type(type_: type) -> bool:
)


def _get_all_basemodel_annotations(
def get_all_basemodel_annotations(
cls: Union[TypeBaseModel, Any], *, default_to_bound: bool = True
) -> dict[str, type]:
# cls has no subscript: cls = FooBar
Expand All @@ -980,7 +980,7 @@ def _get_all_basemodel_annotations(
orig_bases: tuple = getattr(cls, "__orig_bases__", ())
# cls has subscript: cls = FooBar[int]
else:
annotations = _get_all_basemodel_annotations(
annotations = get_all_basemodel_annotations(
get_origin(cls), default_to_bound=False
)
orig_bases = (cls,)
Expand All @@ -994,7 +994,7 @@ def _get_all_basemodel_annotations(
# if class = FooBar inherits from Baz, parent = Baz
if isinstance(parent, type) and is_pydantic_v1_subclass(parent):
annotations.update(
_get_all_basemodel_annotations(parent, default_to_bound=False)
get_all_basemodel_annotations(parent, default_to_bound=False)
)
continue

Expand Down
7 changes: 7 additions & 0 deletions libs/core/tests/unit_tests/runnables/test_runnable.py
Original file line number Diff line number Diff line change
Expand Up @@ -1891,6 +1891,13 @@ async def test_prompt_with_chat_model_async(
)


@pytest.mark.skipif(
condition=sys.version_info[1] == 13,
reason=(
"temporary, py3.13 exposes some invalid assumptions about order of batch async "
"executions."
),
)
@freeze_time("2023-01-01")
async def test_prompt_with_llm(
mocker: MockerFixture, snapshot: SnapshotAssertion
Expand Down
26 changes: 13 additions & 13 deletions libs/core/tests/unit_tests/test_tools.py
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,9 @@
from langchain_core.tools.base import (
InjectedToolArg,
SchemaAnnotationError,
_get_all_basemodel_annotations,
_is_message_content_block,
_is_message_content_type,
get_all_basemodel_annotations,
)
from langchain_core.utils.function_calling import convert_to_openai_function
from langchain_core.utils.pydantic import PYDANTIC_MAJOR_VERSION, _create_subset_model
Expand Down Expand Up @@ -1904,19 +1904,19 @@ class ModelC(Mixin, ModelB):
c: dict

expected = {"a": str, "b": Annotated[ModelA[dict[str, Any]], "foo"], "c": dict}
actual = _get_all_basemodel_annotations(ModelC)
actual = get_all_basemodel_annotations(ModelC)
assert actual == expected

expected = {"a": str, "b": Annotated[ModelA[dict[str, Any]], "foo"]}
actual = _get_all_basemodel_annotations(ModelB)
actual = get_all_basemodel_annotations(ModelB)
assert actual == expected

expected = {"a": Any}
actual = _get_all_basemodel_annotations(ModelA)
actual = get_all_basemodel_annotations(ModelA)
assert actual == expected

expected = {"a": int}
actual = _get_all_basemodel_annotations(ModelA[int])
actual = get_all_basemodel_annotations(ModelA[int])
assert actual == expected

D = TypeVar("D", bound=Union[str, int])
Expand All @@ -1930,7 +1930,7 @@ class ModelD(ModelC, Generic[D]):
"c": dict,
"d": Union[str, int, None],
}
actual = _get_all_basemodel_annotations(ModelD)
actual = get_all_basemodel_annotations(ModelD)
assert actual == expected

expected = {
Expand All @@ -1939,7 +1939,7 @@ class ModelD(ModelC, Generic[D]):
"c": dict,
"d": Union[int, None],
}
actual = _get_all_basemodel_annotations(ModelD[int])
actual = get_all_basemodel_annotations(ModelD[int])
assert actual == expected


Expand All @@ -1961,19 +1961,19 @@ class ModelC(Mixin, ModelB):
c: dict

expected = {"a": str, "b": Annotated[ModelA[dict[str, Any]], "foo"], "c": dict}
actual = _get_all_basemodel_annotations(ModelC)
actual = get_all_basemodel_annotations(ModelC)
assert actual == expected

expected = {"a": str, "b": Annotated[ModelA[dict[str, Any]], "foo"]}
actual = _get_all_basemodel_annotations(ModelB)
actual = get_all_basemodel_annotations(ModelB)
assert actual == expected

expected = {"a": Any}
actual = _get_all_basemodel_annotations(ModelA)
actual = get_all_basemodel_annotations(ModelA)
assert actual == expected

expected = {"a": int}
actual = _get_all_basemodel_annotations(ModelA[int])
actual = get_all_basemodel_annotations(ModelA[int])
assert actual == expected

D = TypeVar("D", bound=Union[str, int])
Expand All @@ -1987,7 +1987,7 @@ class ModelD(ModelC, Generic[D]):
"c": dict,
"d": Union[str, int, None],
}
actual = _get_all_basemodel_annotations(ModelD)
actual = get_all_basemodel_annotations(ModelD)
assert actual == expected

expected = {
Expand All @@ -1996,7 +1996,7 @@ class ModelD(ModelC, Generic[D]):
"c": dict,
"d": Union[int, None],
}
actual = _get_all_basemodel_annotations(ModelD[int])
actual = get_all_basemodel_annotations(ModelD[int])
assert actual == expected


Expand Down

0 comments on commit 5d33732

Please sign in to comment.