refactor: remove client type validation from WeaviateVectorStore init…

…ialization this is taken care by type hints now Signed-off-by: hsm207 <[email protected]>
langchain-ai · Dec 9, 2024 · 8e49a46 · 8e49a46
1 parent 6ba3a58
commit 8e49a46
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 23 deletions.
diff --git a/libs/weaviate/langchain_weaviate/vectorstores.py b/libs/weaviate/langchain_weaviate/vectorstores.py
@@ -99,11 +99,6 @@ def __init__(
     ):
         """Initialize with Weaviate client."""
 
-        if not isinstance(client, weaviate.WeaviateClient):
-            raise ValueError(
-                "client should be an instance of"
-                f" weaviate.WeaviateClient, got {type(client)}"
-            )
         self._client = client
         self._index_name = index_name or f"LangChain_{uuid4().hex}"
         self._embedding = embedding

diff --git a/libs/weaviate/tests/unit_tests/test_vectorstores_integration.py b/libs/weaviate/tests/unit_tests/test_vectorstores_integration.py
@@ -611,24 +611,6 @@ def test_search_with_multi_tenancy(
         docsearch.similarity_search("foo", k=1)
 
 
-def test_invalid_client_type() -> None:
-    with pytest.raises(ValueError) as excinfo:
-        invalid_client = "invalid_client"
-        index_name = "test_index"
-        text_key = "text"
-
-        WeaviateVectorStore(
-            client=invalid_client,
-            index_name=index_name,
-            text_key=text_key,
-        )
-
-    assert (
-        str(excinfo.value)
-        == "client should be an instance of weaviate.WeaviateClient, got <class 'str'>"
-    )
-
-
 def test_embedding_property(
     weaviate_client: Any, consistent_embedding: ConsistentFakeEmbeddings
 ) -> None: