Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for PHP 8 4 and Laminas Coding standards to v3 #91

Merged
merged 5 commits into from
Jan 8, 2025
Merged

Added support for PHP 8 4 and Laminas Coding standards to v3 #91

merged 5 commits into from
Jan 8, 2025

Conversation

visto9259
Copy link
Contributor

@visto9259 visto9259 commented Jan 8, 2025 •
edited
Loading

Q A
Documentation no
Bugfix no
BC Break no
New Feature yes
RFC no
QA yes

Description

  • Added support for PHP 8 4
  • Configured Laminas CI to ignore platform requirements for PHP 8.4.
  • Configured Laminas CI to remove platform requirements for PHP 8.2.
  • Update to Laminas Coding standards to v3 and fixed coding standard issues reported by phpcs

renovate bot and others added 4 commits January 7, 2025 22:41
@renovate @visto9259
Lock file maintenance
a9982d7 
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Eric Richer [email protected] <[email protected]>
@renovate @visto9259
Lock file maintenance
a1d5c87 
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Eric Richer [email protected] <[email protected]>
@visto9259
Added support for PHP 8.4. Configured Laminas CI to ignore platform r…
3634bf5 
…equirements for PHP 8.4

Signed-off-by: Eric Richer [email protected] <[email protected]>
@visto9259
Updated Laminas Coding Standards to v3. Fixed coding standard issues …
7df2863 
…reported by phpcs

Signed-off-by: Eric Richer [email protected] <[email protected]>
samsonasik
samsonasik reviewed Jan 8, 2025
View reviewed changes
.laminas-ci.json Outdated Show resolved Hide resolved
@froschdesign froschdesign added this to the 4.11.0 milestone Jan 8, 2025
@samsonasik
Copy link
Member

Looks good, thank you @visto9259

@samsonasik samsonasik merged commit 9049af6 into laminas:4.11.x Jan 8, 2025
16 checks passed
gsteel
gsteel requested changes Jan 8, 2025
View reviewed changes
Copy link
Member

@gsteel gsteel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happened to the diff with the JSON files? Re-formatted with tabs instead of spaces?, if so, can you revert so that we have a diff only of the changed lines? Sorry to be picky, but it makes a difference when you're trying to figure out what changed and when.

Feel free to push another commit - It can be squashed during merge for a clean history 👍

@gsteel
Copy link
Member

gsteel commented Jan 8, 2025

What happened to the diff with the JSON files? Re-formatted with tabs instead of spaces?, if so, can you revert so that we have a diff only of the changed lines? Sorry to be picky, but it makes a difference when you're trying to figure out what changed and when.

Feel free to push another commit - It can be squashed during merge for a clean history 👍

Ahh - never mind!

@visto9259 visto9259 deleted the update_php_8_4 branch January 8, 2025 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsteel gsteel gsteel requested changes

@samsonasik samsonasik samsonasik approved these changes

Assignees
No one assigned
Labels
Enhancement
Projects
PHP 8.4
Status: Done
Milestone
4.11.0
Development

Successfully merging this pull request may close these issues.
4 participants
@visto9259 @samsonasik @gsteel @froschdesign