Merge pull request #65 from amirkhodabande/refactor_conditions

Refactor conditionals in `AbstractControllerTestCase`
laminas · Nov 13, 2022 · 90de08e · 90de08e
2 parents 3472930 + d56dc0d
commit 90de08e
Showing 1 changed file with 4 additions and 5 deletions.
diff --git a/src/PHPUnit/Controller/AbstractControllerTestCase.php b/src/PHPUnit/Controller/AbstractControllerTestCase.php
@@ -91,7 +91,7 @@ protected function tearDown(): void
      */
     protected function createFailureMessage($message)
     {
-        if (true !== $this->traceError) {
+        if (! $this->traceError) {
             return $message;
         }
 
@@ -291,12 +291,11 @@ public function url($url, $method = HttpRequest::METHOD_GET, $params = [])
     public function dispatch($url, $method = null, $params = [], $isXmlHttpRequest = false)
     {
         if (
-            ! isset($method)
+            ! $method
             && $this->getRequest() instanceof HttpRequest
-            && $requestMethod = $this->getRequest()->getMethod()
         ) {
-            $method = $requestMethod;
-        } elseif (! isset($method)) {
+            $method = $this->getRequest()->getMethod();
+        } elseif (! $method) {
             $method = HttpRequest::METHOD_GET;
         }