-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the ability to store multipart/alternative messages #36
base: 2.13.x
Are you sure you want to change the base?
Add the ability to store multipart/alternative messages #36
Commits on Nov 20, 2023
-
Add the ability to store multipart/alternative messages
This change adds the ability to properly parse messages where the content type is "multipart/alternative" into multiple Part objects. Previously, the "multipart/alternative" content-type header would be ignored, leaving alternative parts being rolled into one larger Part object. Signed-off-by: Matthew Setter <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 1e3264c - Browse repository at this point
Copy the full SHA 1e3264cView commit details -
This is a small change to correct some minor points in the related documentation. Signed-off-by: Matthew Setter <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for b9b26d9 - Browse repository at this point
Copy the full SHA b9b26d9View commit details
Commits on Nov 23, 2023
-
Use an existing constant instead of adding a new one
I wasn't aware at the time that I created the previous commit with the constant, of the existence of a constant with the same value. So this commit removes my duplicate constant, replacing it with the existing one. Signed-off-by: Matthew Setter <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 8c94034 - Browse repository at this point
Copy the full SHA 8c94034View commit details -
Co-authored-by: Matthew Weier O'Phinney <[email protected]> Signed-off-by: Matthew Setter <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for a808e7d - Browse repository at this point
Copy the full SHA a808e7dView commit details -
Fix type hinting of the parts property
As per @MWOP's suggestion, this change properly typehints the protected $parts property in Part to return an array of Part objects. Signed-off-by: Matthew Setter <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 2012f86 - Browse repository at this point
Copy the full SHA 2012f86View commit details -
Signed-off-by: Matthew Setter <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for ee273da - Browse repository at this point
Copy the full SHA ee273daView commit details -
Add further assertions when testing multipart alternative messages
This change adds a series of assertions for attachments on multipart/alternative messages, to help verify that they contain what they're expected to contain. I felt that it was helpful to have assertions for attachments (or non text/HTML content) as well, so that more of the code could be properly tested. Signed-off-by: Matthew Setter <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 06f3ab8 - Browse repository at this point
Copy the full SHA 06f3ab8View commit details -
Remove domain-specific references
These were originally used because it was a fairly generic email that I had at the time, while writing the tests. However, as per @MWOP's suggestion, it should be more generic (and not preference a given, commercial, email provider). Signed-off-by: Matthew Setter <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f67b0c0 - Browse repository at this point
Copy the full SHA f67b0c0View commit details
Commits on Nov 29, 2023
-
Set a Part filename if the part stores an attachment
This change simplistically sets a Part's filename property if the content disposition header is set, it's an attachment, and the filename property is set. I've deliberately avoided any considerations about sanitising the filename, deciding, at this stage, to leave that to the calling code up the line. Signed-off-by: Matthew Setter <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 93c2cd6 - Browse repository at this point
Copy the full SHA 93c2cd6View commit details
Commits on Dec 15, 2023
-
Correct a small bug in setting an attachment's filename
Previously, the code only set a filename for a message part if the part contained a content-disposition header where the disposition type was set to "attachment" and the filename parameter was set. After re-reading https://www.w3.org/Protocols/HTTP/Issues/content-disposition.txt, I see that this was wrong, as the content-disposition header can have the filename parameter set if the type is attachment or inline. This commit corrects that earlier mistake. Signed-off-by: Matthew Setter <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 6e7adfd - Browse repository at this point
Copy the full SHA 6e7adfdView commit details