Fixes #23 ensure trim() on ContentType::addParameter()

Signed-off-by: Abdul Malik Ikhsan <[email protected]>
laminas · Jul 24, 2020 · a39d6f2 · a39d6f2
1 parent aa1a4c9
commit a39d6f2
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/src/Header/ContentType.php b/src/Header/ContentType.php
@@ -143,7 +143,7 @@ public function getType()
      */
     public function addParameter($name, $value)
     {
-        $name  = strtolower($name);
+        $name  = trim(strtolower($name));
         $value = (string) $value;
 
         if (! HeaderValue::isValid($name)) {

diff --git a/test/Header/ContentTypeTest.php b/test/Header/ContentTypeTest.php
@@ -222,6 +222,12 @@ public function testGetParameter()
         $this->assertSame('top', $header->getParameter('level'));
     }
 
+    public function testGetParameterWithSpaceTrimmed()
+    {
+        $header = ContentType::fromString('content-type: text/plain; level=top; name="logfile.log";');
+        $this->assertSame('logfile.log', $header->getParameter('name'));
+    }
+
     public function testGetParameterNotExists()
     {
         $header = ContentType::fromString('content-type: text/plain');