Merge pull request #230 from boesing/bugfix/normalize-base-ref

Properly parse `GITHUB_BASE_REF`
laminas · Jul 11, 2023 · a32891f · a32891f
2 parents c741f71 + 7a0c9d2
commit a32891f
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/src/config/app.ts b/src/config/app.ts
@@ -467,6 +467,12 @@ export default function createConfig(
 
     configurationFromFile.extensions?.forEach((extension) => phpExtensions = phpExtensions.add(extension));
 
+    let baseReference: string|null = (process.env.GITHUB_BASE_REF ?? '').replaceAll('"', '');
+
+    if (baseReference === '') {
+        baseReference = null;
+    }
+
     return {
         codeChecks                    : requirements.codeChecks,
         docLinting                    : requirements.docLinting,
@@ -480,7 +486,7 @@ export default function createConfig(
         ignorePhpPlatformRequirements : configurationFromFile.ignore_php_platform_requirements ?? {},
         additionalComposerArguments   : [ ... new Set(configurationFromFile.additional_composer_arguments ?? []) ],
         backwardCompatibilityCheck    : configurationFromFile.backwardCompatibilityCheck ?? false,
-        baseReference                 : process.env.GITHUB_BASE_REF ?? null,
+        baseReference                 : baseReference,
     };
 }
 

diff --git a/tests/code-check-roave-backward-compatibility/test.env b/tests/code-check-roave-backward-compatibility/test.env
@@ -1 +1 @@
-GITHUB_BASE_REF=1111222233334444aaaabbbbccccdddd
+GITHUB_BASE_REF="1111222233334444aaaabbbbccccdddd"