Skip to content

Commit

Permalink
qa: replace Dockerfile node check with a dedicated job `package-l…
Browse files Browse the repository at this point in the history
…ock-up-to-date`

That new job uses `package-lock-utd` package to verify `package-lock.json` is up2date with what `package.json` requires.

Signed-off-by: Maximilian Bösing <[email protected]>
  • Loading branch information
boesing committed Apr 24, 2024
1 parent bf9f170 commit 7961bb3
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 1 deletion.
11 changes: 11 additions & 0 deletions .github/workflows/continuous-integration.yml
Original file line number Diff line number Diff line change
Expand Up @@ -154,3 +154,14 @@ jobs:
run: "npm ci"
- name: Run Jest
run: "npm run test"

package-lock-up-to-date:
runs-on: "ubuntu-latest"
steps:
- uses: "actions/checkout@v4"
- uses: "actions/setup-node@v4"
with:
check-latest: true
node-version: 21
- name: "Check package-lock.json is up2date"
run: "npx --yes package-lock-utd"
1 change: 0 additions & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ COPY package*.json ./
COPY tsconfig.json ./
COPY webpack.config.ts ./
RUN npm ci
RUN apk add --no-cache jq && npx semver -r $(jq -r '.packages."".engines.node' package-lock.json) $(node -v) || (echo "ERROR: package-lock.json is not synchronized with Dockerfile node version." && exit 1)
COPY ./src ./src
RUN npm run build

Expand Down

0 comments on commit 7961bb3

Please sign in to comment.