Ontology builder parallelization #92
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lambdamusic
requested changes
Jul 3, 2020
There was a problem hiding this comment.
Hi, thanks a lot for the suggestions. I am not very familiar with multiprocessing but I tried to run your code:
- indentation is messed up and there seems to be missing bits too
joblibis not added torequirements.txtmultiprocessingdoes NOT need to be addedrequirements.txtas it is included in python3 by default
All in all, seems a nice idea. If you can make it work at your end, I'll test again.
|
Closing due to inactivity |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extending on issue #44 the function
ontology_builderwas optimized to parallelize itself across the number of CPU cores.