Make handling of Girouette return vals more general #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most of the time we get a [".class-name" {styling}] tuple, but we may also get a
CSSAtValue, or possibly any number of special Garden things. So instead of
special-casing these patterns, we walk whatever we get, replacing the classname
of the current token with `:&`. In a second pass we unpack the pattern `[:&
styling]`, this isn't necessary, but helps create more compact CSS.
|
Also add some more tests for undocumented features. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the time we get a
[".class-name" {styling}]tuple, but we may also get aCSSAtValue, or possibly any number of special Garden things. So instead ofspecial-casing these patterns, we walk whatever we get, replacing the classname
of the current token with
:&. In a second pass we unpack the pattern[:& styling], this isn't necessary, but helps create more compact CSS.