This repository has been archived by the owner on Jul 22, 2024. It is now read-only.
test: kakarot #1260
Open
test: kakarot #1260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oppen
reviewed
Mar 27, 2024
src/utils.rs
Outdated
Comment on lines
125
to
130
| let mut output = [0; 32]; | ||
|
|
||
| let bytes = value.to_bytes_be(); | ||
| output[32 - bytes.len()..].copy_from_slice(&bytes); | ||
| output[..].copy_from_slice(&bytes); | ||
|
|
||
| ClassHash(output) |
There was a problem hiding this comment.
I think you could even just do this:
pub fn felt_to_hash(value: &Felt252) -> ClassHash {
ClassHash(value.to_bytes_be())
}
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kakarot testing in SiR
Description
Adds a simple EVM contract execution using Kakarot in the integration tests from SiR.
Description of the pull request changes and motivation.
Checklist