Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

Sandboxed cairo native #1209

Draft
wants to merge 18 commits into
base: main
Choose a base branch
from
Draft

Sandboxed cairo native #1209

wants to merge 18 commits into from

Conversation

edg-l
Copy link
Member

@edg-l edg-l commented Jan 26, 2024

Untitled-2024-01-29-1217

Todo: error reporting

Moved from lambdaclass/cairo_native#417

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.

@codecov-commenter
Copy link

codecov-commenter commented Jan 26, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (15a1e6e) 89.07% compared to head (37cddc8) 89.23%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1209      +/-   ##
==========================================
+ Coverage   89.07%   89.23%   +0.15%     
==========================================
  Files          52       52              
  Lines       15586    15832     +246     
==========================================
+ Hits        13884    14127     +243     
- Misses       1702     1705       +3     
Files Coverage Δ
src/execution/execution_entry_point.rs 94.78% <100.00%> (+0.01%) ⬆️
src/syscalls/business_logic_syscall_handler.rs 79.97% <100.00%> (+0.60%) ⬆️
...calls/deprecated_business_logic_syscall_handler.rs 92.20% <100.00%> (+0.28%) ⬆️
src/syscalls/deprecated_syscall_handler.rs 98.47% <100.00%> (+0.02%) ⬆️
src/syscalls/syscall_handler.rs 80.83% <100.00%> (+0.32%) ⬆️
src/transaction/declare.rs 91.63% <100.00%> (+0.27%) ⬆️
src/transaction/declare_v2.rs 89.21% <100.00%> (+0.07%) ⬆️
src/transaction/deploy.rs 91.51% <100.00%> (+0.25%) ⬆️
src/transaction/deploy_account.rs 78.57% <100.00%> (+0.79%) ⬆️
src/transaction/error.rs 75.00% <ø> (ø)
... and 5 more

@edg-l edg-l marked this pull request as ready for review January 29, 2024 15:37
@edg-l edg-l marked this pull request as draft January 29, 2024 19:03
@igaray igaray mentioned this pull request Jan 31, 2024
5 tasks
@edg-l edg-l marked this pull request as ready for review February 1, 2024 12:29
@@ -385,6 +385,8 @@ where
&BlockContext::default(),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you re-run the benchmarks? in that case please share the numbers

@@ -0,0 +1,443 @@
use std::{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this module should be only included if the cairo native feature is set

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thats the case already, please see

#[cfg(feature = "cairo-native")]
pub mod sandboxing;

on lib.rs

Copy link
Member

@juanbono juanbono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see comments

@edg-l edg-l marked this pull request as draft February 7, 2024 14:02
@edg-l
Copy link
Member Author

edg-l commented Feb 7, 2024

Status:

Needs to fix ci and yas benchmark being slow when using sandbox.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants