Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

perf: remove intermediate contract deserialization #1050

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Oppen
Copy link
Member

@Oppen Oppen commented Sep 27, 2023

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Sep 27, 2023

Codecov Report

Merging #1050 (b5d138a) into main (484acb3) will decrease coverage by 0.13%.
The diff coverage is 81.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1050      +/-   ##
==========================================
- Coverage   90.16%   90.04%   -0.13%     
==========================================
  Files          49       49              
  Lines       12970    12913      -57     
==========================================
- Hits        11694    11627      -67     
- Misses       1276     1286      +10     
Files Coverage Δ
src/serde_structs/mod.rs 100.00% <100.00%> (ø)
.../api/contract_classes/deprecated_contract_class.rs 75.80% <100.00%> (-6.76%) ⬇️
src/core/contract_address/casm_contract_address.rs 93.50% <0.00%> (-1.24%) ⬇️
...c/core/contract_address/sierra_contract_address.rs 91.66% <0.00%> (-0.70%) ⬇️
src/execution/execution_entry_point.rs 96.99% <0.00%> (-0.23%) ⬇️

@Oppen Oppen marked this pull request as ready for review October 5, 2023 21:18
This requires a few ugly hacks from mismatches with Blockifier's
version.

TODO: comment on them!
@Oppen Oppen force-pushed the perf/deserialize_deprecated_contract branch from 5caa94d to b5d138a Compare October 5, 2023 21:20
@Oppen Oppen marked this pull request as draft October 5, 2023 21:21
@Oppen Oppen marked this pull request as ready for review October 9, 2023 20:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants