Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert builtin cost rework #874

Merged
merged 2 commits into from
Oct 21, 2024
Merged

Revert builtin cost rework #874

merged 2 commits into from
Oct 21, 2024

Conversation

pefontana
Copy link
Member

We need to revert this changes, because they are causing some errors when re-executing blocks in Starknet Replay

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 83.33333% with 7 lines in your changes missing coverage. Please review.

Project coverage is 82.82%. Comparing base (4ba9e16) to head (9dffb61).

Files with missing lines Patch % Lines
src/executor/contract.rs 50.00% 4 Missing ⚠️
src/types.rs 0.00% 2 Missing ⚠️
src/executor.rs 92.85% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #874      +/-   ##
==========================================
- Coverage   82.83%   82.82%   -0.01%     
==========================================
  Files         120      120              
  Lines       35148    34941     -207     
==========================================
- Hits        29114    28941     -173     
+ Misses       6034     6000      -34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Benchmarking results

Benchmark for program factorial_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 11.027 ± 0.308 10.612 11.359 24.60 ± 0.69
cairo-native (embedded AOT) 3.183 ± 0.021 3.155 3.218 7.10 ± 0.05
cairo-native (embedded JIT using LLVM's ORC Engine) 3.246 ± 0.029 3.209 3.314 7.24 ± 0.07
cairo-native (standalone AOT) 0.674 ± 0.001 0.672 0.675 1.50 ± 0.00
cairo-native (standalone AOT with -march=native) 0.448 ± 0.000 0.448 0.449 1.00

Benchmark for program fib_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 11.067 ± 0.328 10.630 11.554 1337.80 ± 44.22
cairo-native (embedded AOT) 2.898 ± 0.037 2.850 2.960 350.26 ± 6.76
cairo-native (embedded JIT using LLVM's ORC Engine) 2.912 ± 0.041 2.844 2.985 352.03 ± 7.15
cairo-native (standalone AOT) 0.009 ± 0.000 0.008 0.009 1.04 ± 0.02
cairo-native (standalone AOT with -march=native) 0.008 ± 0.000 0.008 0.009 1.00

Benchmark for program logistic_map

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 4.506 ± 0.038 4.438 4.551 63.49 ± 0.59
cairo-native (embedded AOT) 3.050 ± 0.040 3.004 3.110 42.97 ± 0.58
cairo-native (embedded JIT using LLVM's ORC Engine) 3.112 ± 0.037 3.042 3.153 43.85 ± 0.55
cairo-native (standalone AOT) 0.115 ± 0.000 0.115 0.115 1.62 ± 0.01
cairo-native (standalone AOT with -march=native) 0.071 ± 0.000 0.071 0.072 1.00

Copy link

Benchmark results Main vs HEAD.

Command Mean [s] Min [s] Max [s] Relative
head factorial_2M.cairo (JIT) 3.164 ± 0.028 3.119 3.203 1.02 ± 0.01
base factorial_2M.cairo (JIT) 3.145 ± 0.016 3.122 3.172 1.01 ± 0.01
head factorial_2M.cairo (AOT) 3.113 ± 0.033 3.063 3.166 1.00
base factorial_2M.cairo (AOT) 3.141 ± 0.028 3.091 3.176 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
head fib_2M.cairo (JIT) 2.667 ± 0.016 2.639 2.693 1.00 ± 0.02
base fib_2M.cairo (JIT) 2.691 ± 0.024 2.665 2.742 1.01 ± 0.02
head fib_2M.cairo (AOT) 2.660 ± 0.040 2.602 2.722 1.00
base fib_2M.cairo (AOT) 2.672 ± 0.038 2.607 2.717 1.00 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
head logistic_map.cairo (JIT) 2.991 ± 0.039 2.933 3.044 1.04 ± 0.02
base logistic_map.cairo (JIT) 3.008 ± 0.047 2.957 3.087 1.05 ± 0.02
head logistic_map.cairo (AOT) 2.879 ± 0.037 2.831 2.943 1.00 ± 0.02
base logistic_map.cairo (AOT) 2.870 ± 0.046 2.813 2.959 1.00

@edg-l edg-l added this pull request to the merge queue Oct 21, 2024
Merged via the queue into main with commit 355c250 Oct 21, 2024
15 checks passed
@edg-l edg-l deleted the remove-builtin-cost-rework branch October 21, 2024 17:03
edg-l added a commit that referenced this pull request Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants